-
-
Notifications
You must be signed in to change notification settings - Fork 400
[type-declaration] Add AddReturnTypeFromTryCatchTypeRector #7099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Jul 30, 2025
rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php
Show resolved
Hide resolved
samsonasik
reviewed
Jul 30, 2025
rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php
Outdated
Show resolved
Hide resolved
samsonasik
reviewed
Jul 30, 2025
rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php
Outdated
Show resolved
Hide resolved
6839803
to
794caed
Compare
samsonasik
reviewed
Jul 30, 2025
rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php
Outdated
Show resolved
Hide resolved
e451ff7
to
1da87a2
Compare
samsonasik
requested changes
Jul 30, 2025
...aration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector/Fixture/skip_doc_type.php.inc
Show resolved
Hide resolved
samsonasik
reviewed
Jul 30, 2025
rules/TypeDeclaration/Rector/ClassMethod/AddReturnTypeFromTryCatchTypeRector.php
Outdated
Show resolved
Hide resolved
9a50ad3
to
1b25d9f
Compare
1b25d9f
to
c2d96ae
Compare
I will add test+fix for try + catch + finally with different type in separate PR :) |
I created new PR for it: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.