[Php80] Make configurable to allow skip on model based classes on ClassPropertyAssignToConstructorPromotionRector #7043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
implemented /cc @ruudk |
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
|
Amazing thanks so much ⚡️ |
samsonasik
changed the title
TomasVotruba
reviewed
Jul 5, 2025
| @@ -46,12 +57,26 @@ public function resolveFromClass(Class_ $class, ClassMethod $constructClassMetho | |||
| continue; | |||
| } | |||
|
|
|||
| if (! $allowModelBasedClasses && $this->hasModelTypeCheck($property, 'JMS\Serializer\Annotation\Type')) { | |||
There was a problem hiding this comment.
Better use class constant enum here , to keep classes separated and non-prefixed
There was a problem hiding this comment.
sure, updated to use class name constant enum 2ad2fd5 👍
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow configure like this:
default to true.
Closes rectorphp/rector#9243