Skip to content

[Attribute] Handle comment below @dataProvider doc on DataProviderAnnotationToAttributeRector #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jul 2, 2025

Fixes #499

when comment is above @dataProvider, it can be kept, when below, it marked as part of it, so it removed.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready, comment below @dataProvider directly is removed on purpose, as part of it the doc itself.

@TomasVotruba TomasVotruba merged commit b9e107e into main Jul 2, 2025
6 checks passed
@TomasVotruba TomasVotruba deleted the remove-comment-below branch July 2, 2025 12:57
@TomasVotruba
Copy link
Member

Great work 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataProviderAnnotationToAttributeRector breaks PHPDoc
2 participants