[Demo] Add "Tips" config to demonstrate rule on specific PHP version #3057
Conversation
samsonasik
commented
May 22, 2025
samsonasik
commented
samsonasik
changed the title
|
@TomasVotruba ready for review 👍 |
|
I like the idea 👍 This could be better in the config itself, like rules and sets. |
|
@TomasVotruba sure, moved to config 301317f
|
samsonasik
changed the title
samsonasik
changed the title
|
Ready to merge 👍 |
|
|
||
| return RectorConfig::configure() | ||
| // A. whole set | ||
| ->withPreparedSets(typeDeclarations: true) | ||
| // B. or few rules | ||
| ->withRules([ | ||
| TypedPropertyFromAssignsRector::class | ||
| ]); | ||
| ]) | ||
| ->withPhpVersion(PhpVersion::PHP_82); |
There was a problem hiding this comment.
I think the 8.4 would be better, as this one would disable all the new rules.
Why should we have this option here? It's rarely used in practice. I'd like to avoid spreading configuration, that's only for hackers 😁
There was a problem hiding this comment.
sure, updated to php 8.4 👍 c0dcb1c
There was a problem hiding this comment.
The reason config here is when people try php 8.3+ rule, while our server still on php 8.2, we don't have composer.json included in demo page, so defined config may needed.
upgrading to latest php 8.4 on server will currently a little bit challenging imo, last time I upgraded to php 8.2, it took some time to up correctly.
