Replace Blog link with Wiki link #329
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated blog view and route, replaces it with a Wiki link in the navigation, updates the Storybook iframe styling, and introduces a reusable TargetBlankLink component for external links.
- Drop BlogView imports/exports and route
- Rename iframe class from
.storybookto.fullscreenand adjust Storybook component - Add
TargetBlankLinkand update navigation links to use it
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/index.ts | Removed BlogView import/export |
| src/views/iframe.scss | Renamed .storybook selector to .fullscreen |
| src/views/Storybook.tsx | Switched CSS import from Storybook.scss to iframe.scss and updated className |
| src/views/BlogView.scss | Deleted unused BlogView SCSS |
| src/views/BlogView.js | Deleted BlogView component file |
| src/routes/index.tsx | Removed blog route and named the default export function |
| src/layouts/Frame.tsx | Removed blog nav item, added Wiki link and switched to TargetBlankLink |
| src/components/Shared/TargetBlankLink.tsx | Added new component for external links |
Comments suppressed due to low confidence (2)
src/views/Storybook.tsx:2
- [nitpick] Storybook.scss is no longer imported or used after switching to iframe.scss; consider deleting Storybook.scss to remove stale assets.
import './iframe.scss';
src/components/Shared/TargetBlankLink.tsx:1
- The new TargetBlankLink component lacks unit tests; consider adding tests to cover its rendering and props behavior.
import { ReactNode } from 'react';
|
|
||
| export function TargetBlankLink({ href, children }: TargetBlankLinkProps) { | ||
| return ( | ||
| <a href={href} target="_blank" rel="noopener noreferrer"> |
There was a problem hiding this comment.
[nitpick] For better accessibility, add an aria-label (e.g., aria-label="opens link in new tab") to the link to clearly indicate its behavior to screen readers.
| <a href={href} target="_blank" rel="noopener noreferrer"> | |
| <a href={href} target="_blank" rel="noopener noreferrer" aria-label="opens link in new tab"> |
Copilot uses AI. Check for mistakes.
| @@ -1,4 +1,4 @@ | |||
| iframe.storybook { | |||
| iframe.fullscreen { | |||
There was a problem hiding this comment.
[nitpick] The .fullscreen class and iframe.scss filename are generic; consider using a more specific naming (e.g., .storybook-fullscreen, storybook-iframe.scss) to avoid naming conflicts.
| iframe.fullscreen { | |
| iframe.storybook-fullscreen { |
Copilot uses AI. Check for mistakes.
No description provided.