chore(SidebarLink): update effect deps #5745
Conversation
Size Changes📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 Three Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
Change for:
Boolean(ref)is always true.Some other question:
As doc says, u should not suppress deps linter. In user code, it's easy to change code to fit it. However, checking the reference stability of a library hook's return value, especially when it's a function, can be challenging as it requires inspecting the source code. In some case, I have to suppress deps linter because libray code return a function that is not wrapped by useCallback and changes its reference on every render. I also want to know, even if the return value is stable like ref, should I still add it to deps list? Will it affect the future Forget compiler work? In usePendingRoutes, it seems omit events return by useRouter.