Skip to content

Swap sections in useEffect reference for improved clarity/flow #4040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

solkaz
Copy link

@solkaz solkaz commented Nov 4, 2021

The "Cleaning up an effect" section for the useEffect hook ends with a note that the next section would contain instructions on how to "avoid firing an effect on every update." This most likely refers to the content in the "Conditionally firing an effect" section, but prior to this commit, it did not immediately proceed the "Cleaning up an Effect" section (instead it was the "Timing of effects" section, then the "Conditionally firing an effect" section). This commit swaps the two so that the closing sentence of the "Cleaning up an Effect" section makes sense.

The "Cleaning up an effect" section for the `useEffect` hook ends with a note that the next section would contain instructions on how to "avoid firing an effect on every update." This most likely refers to the content in the "Conditionally firing an effect" section, but prior to this commit, it did not immediately proceed the "Cleaning up an Effect" section (instead it was the "Timing of effects" section, then the "Conditionally firing an effect" section). This commit swaps the two so that the closing sentence of the "Cleaning up an Effect" section makes sense.
@solkaz solkaz changed the title Swap sections in useEffect reference Swap sections in useEffect reference for improved clarity/flow Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants