add empty dependencies to useEffect in custom hook docs #3188
Conversation
The useEffect in https://reactjs.org/docs/hooks-custom.html#extracting-a-custom-hook is missing the empty dependency array
justin-hackin
changed the title
|
Hi @justin-hackin! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Should the dependency be actually a 'friendID', so example where we selecting 'recipientID' works correctly? |
The useEffect in https://reactjs.org/docs/hooks-custom.html#extracting-a-custom-hook is missing the empty dependency array