Skip to content

docs:(content/docs/strict-mode.md) fixed the documentation around strict mode double invoking function component bodies but only those which use hooks #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vivek12345
Copy link

Currently the documentation says it will double invoke function component bodies in strict mode. This can get slightly confusing in a scenario like this sandbox
https://codesandbox.io/s/inspiring-water-892dq?file=/src/App.js

Here only the function component body of H1 is being double invoked as it has a call to a react hook useEffect.

Functional component H2 in above sandbox is only being called once.

This is the reason I feel adding a little more context around the documentation for double invoking of functional component bodies will help the users.

…ict mode double invoking function component bodies but only those which use hooks
@facebook-github-bot
Copy link
Collaborator

Hi @vivek12345!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants