Skip to content

[WIP] Make project Swift 6 compatible #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 47 commits into
base: master
Choose a base branch
from
Draft

[WIP] Make project Swift 6 compatible #1091

wants to merge 47 commits into from

Conversation

qvacua
Copy link
Owner

@qvacua qvacua commented Dec 29, 2024

The goals of this PR are:

  • MsgpackRpc and NvimApi do not use RxSwift, but uses Swift concurrency.
  • Make all targets Swift 6 compatible
  • Increase the minimal macOS deployment version to macOS 13.5
  • Remove RxSwift dependency; remove the use of observables as much as possible, use Combine where appropriate

Broken due to refactoring:

  • Complex input methods
  • It looks like a memory leak has been introduced in VimR target

Not included in this PR:

  • Refactor to make the whole project more async/await-y

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha
@qvacua qvacua marked this pull request as draft December 29, 2024 19:43
@qvacua qvacua self-assigned this Dec 29, 2024
qvacua added 7 commits January 8, 2025 20:33

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha
 Conflicts:
	NvimView/Sources/NvimView/NvimView+Key.swift
	RxPack/Sources/RxNeovim/RxNeovimApi.generated.swift
	bin/neovim/resources/buildInfo.json

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha
qvacua added 10 commits March 2, 2025 22:48

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha
qvacua added 2 commits April 2, 2025 21:15

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha
qvacua added 7 commits April 3, 2025 07:55

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha
 Conflicts:
	Neovim
	NvimApi/bin/generate_async_api_methods.py
	NvimView/Sources/NvimView/NvimAutoCommandEvent.generated.swift
	NvimView/Sources/NvimView/NvimCursorModeShape.generated.swift
	RxPack/Sources/RxNeovim/RxNeovimApi.generated.swift
	VimR/VimR.xcodeproj/project.pbxproj
	VimR/VimR/Info.plist
	VimR/VimRTests/Info.plist
	appcast.xml
	appcast_snapshot.xml
	bin/neovim/resources/buildInfo.json
	resources/release-notes.md

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha

Verified

This commit was signed with the committer’s verified signature.
qvacua Tae Won Ha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant