Improve some of the incomplete types in tkinter.filedialog
#14311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
brianschubert
approved these changes
Jun 20, 2025
stdlib/tkinter/filedialog.pyi
Outdated
| def files_select_event(self, event) -> None: ... | ||
| def ok_event(self, event) -> None: ... | ||
| how: str | None | ||
| def go(self, dir_or_file: StrOrBytesPath = ".", pattern: str = "*", default: str = "", key: Hashable | None = None): ... |
There was a problem hiding this comment.
Looks like dir_or_file gets joined with a string, so a bytes path won't work. pattern and default are both processed through os.path.* functions, so a path-like can be accepted
Suggested change
| def go(self, dir_or_file: StrOrBytesPath = ".", pattern: str = "*", default: str = "", key: Hashable | None = None): ... | |
| def go(self, dir_or_file: StrPath = ".", pattern: StrPath = "*", default: StrPath = "", key: Hashable | None = None): ... |
stdlib/tkinter/filedialog.pyi
Outdated
| def get_filter(self) -> tuple[str, str]: ... | ||
| def get_selection(self) -> str: ... | ||
| def cancel_command(self, event: Event | None = None) -> None: ... | ||
| def set_filter(self, dir: StrOrBytesPath, pat: str) -> None: ... |
There was a problem hiding this comment.
Suggested change
| def set_filter(self, dir: StrOrBytesPath, pat: str) -> None: ... | |
| def set_filter(self, dir: StrPath, pat: StrPath) -> None: ... |
stdlib/tkinter/filedialog.pyi
Outdated
| def get_selection(self) -> str: ... | ||
| def cancel_command(self, event: Event | None = None) -> None: ... | ||
| def set_filter(self, dir: StrOrBytesPath, pat: str) -> None: ... | ||
| def set_selection(self, file: str) -> None: ... |
There was a problem hiding this comment.
Suggested change
| def set_selection(self, file: str) -> None: ... | |
| def set_selection(self, file: StrPath) -> None: ... |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved some of the incomplete types in the
tkinter.filedialogmodule.