-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Add asyncio.tools
stubs for 3.14
#14305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brianschubert
wants to merge
2
commits into
python:main
Choose a base branch
from
brianschubert:stdlib-asyncio-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
from collections.abc import Iterable | ||
from enum import Enum | ||
from typing import NamedTuple, SupportsIndex, type_check_only | ||
|
||
@type_check_only | ||
class _AwaitedInfo(NamedTuple): # AwaitedInfo_Type from _remote_debugging | ||
thread_id: int | ||
awaited_by: list[_TaskInfo] | ||
|
||
@type_check_only | ||
class _TaskInfo(NamedTuple): # TaskInfo_Type from _remote_debugging | ||
task_id: int | ||
task_name: str | ||
coroutine_stack: list[_CoroInfo] | ||
awaited_by: list[_TaskInfo] | ||
brianschubert marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
@type_check_only | ||
class _CoroInfo(NamedTuple): # CoroInfo_Type from _remote_debugging | ||
call_stack: list[_FrameInfo] | ||
task_name: int | str | ||
|
||
@type_check_only | ||
class _FrameInfo(NamedTuple): # FrameInfo_Type from _remote_debugging | ||
filename: str | ||
lineno: int | ||
funcname: str | ||
|
||
class NodeType(Enum): | ||
COROUTINE = 1 | ||
TASK = 2 | ||
|
||
class CycleFoundException(Exception): | ||
cycles: list[list[int]] | ||
id2name: dict[int, str] | ||
def __init__(self, cycles: list[list[int]], id2name: dict[int, str]) -> None: ... | ||
|
||
def get_all_awaited_by(pid: SupportsIndex) -> list[_AwaitedInfo]: ... | ||
def build_async_tree(result: Iterable[_AwaitedInfo], task_emoji: str = "(T)", cor_emoji: str = "") -> list[list[str]]: ... | ||
def build_task_table(result: Iterable[_AwaitedInfo]) -> list[list[int | str]]: ... | ||
def display_awaited_by_tasks_table(pid: SupportsIndex) -> None: ... | ||
def display_awaited_by_tasks_tree(pid: SupportsIndex) -> None: ... |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also don't think that comments are appropriate here since exactly the same namedtuples are also defined in tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think they serve a purpose, but I'm happy to remove them if that's preferred. They document that these are actually struct sequence types from
_remote_debugging
, which typeshed doesn't have stubs for (yet). If typeshed later adds stubs for_remote_debugging
, we'd likely want to replace these, so I think it's helpful to have some note reminding us of what these types represent. (Typing the real struct sequence types is a bit trickier, which is why I just used a local approximation here)