Skip to content

Improve error handling and add loading state in List component #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve error handling and add loading state in List component #1487

wants to merge 3 commits into from
+51 −2

Conversation

metalmatze
Copy link
Member

@metalmatze metalmatze commented May 24, 2025 •
edited
Loading

Fixes #1130

Summary

  • Improved error message wording to be more concise and user-friendly
  • Added loading spinner to provide visual feedback while objectives are being fetched
  • Enhanced overall user experience with clearer state transitions

Changes

Error Message Improvements

  • NotFound: Changed "Service Level Objectives not found" → "No Service Level Objectives found"
  • Unavailable: Changed "Unable to connect to backend components" → "Backend connection failed"
  • Generic Error: Changed "Error" → "Error loading objectives"
  • Removed redundant wording and simplified instructions
  • Fixed template literal syntax issue

Loading State

  • Added centered spinner animation while data is loading
  • Displays "Loading objectives..." message for clarity
  • Properly checks loading state before error states

Screenshots

Loading State

loading

Backend Unavailable State

unavailable

Test Plan

  • Verify loading spinner appears when fetching objectives
  • Test NotFound error message when no objectives exist
  • Test Unavailable error when backend is not running
  • Ensure smooth transitions between states
  • Verify error messages are clear and actionable

🤖 Generated with Claude Code

Sorry, something went wrong.

metalmatze and others added 3 commits May 24, 2025 22:16
@metalmatze @claude
Improve error handling messages in List component
9096b11 
- Made error messages more concise and user-friendly
- Changed "Service Level Objectives not found" to "No Service Level Objectives found"
- Simplified backend connection error message
- Added context to generic error message ("Error loading objectives")
- Fixed template literal syntax in error display

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@metalmatze @claude
Add loading spinner to List component
Loading
Loading status checks…
f4385bc 
- Display a centered spinner with "Loading objectives..." message while data is being fetched
- Check for loading status before checking for errors
- Improves user experience by providing visual feedback during data loading

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@metalmatze
Ignore the NotFound case for now.
Loading
Loading status checks…
f43bc90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue when showing some SLOs (white screen)
1 participant
@metalmatze