-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: Support python.exe fallback on Windows #2919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
esafak
wants to merge
6
commits into
pypa:main
Choose a base branch
from
esafak:windows-python3-fallback
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, when discovering Python interpreters via PEP 514, if the `ExecutablePath` is not present in the registry, the discovery mechanism will now look for `python3.exe` first, and then fall back to `python.exe`. This allows virtualenv to discover Python on Windows installations that use the `python.exe` executable name. Fixes pypa#2774 Signed-off-by: Emre Şafak <[email protected]>
gaborbernat
approved these changes
Aug 1, 2025
gaborbernat
previously approved these changes
Aug 1, 2025
On Windows, when discovering Python interpreters via PEP 514, if the `ExecutablePath` is not present in the registry, the discovery mechanism will now look for `python3.exe` first, and then fall back to `python.exe` for Python 3, and only `python.exe` for Python 2. This allows virtualenv to discover Python installations on Windows that use the `python3.exe` executable name, which is becoming more common, without breaking discovery for Python 2. A test case has been added to verify this new behavior. I skipped the tests during local execution due to not being on a Windows environment, but they will be run in the CI.
auto-merge was automatically disabled
August 1, 2025 00:13
Head branch was pushed to by a user without write access
On Windows, when discovering Python interpreters via PEP 514, if the `ExecutablePath` is not present in the registry, the discovery mechanism will now look for `python3.exe` first, and then fall back to `python.exe` for Python 3, and only `python.exe` for Python 2. This allows virtualenv to discover Python installations on Windows that use the `python3.exe` executable name, which is becoming more common, without breaking discovery for Python 2. A test case has been added to verify this new behavior.
On Windows, when discovering Python interpreters via PEP 514, if the `ExecutablePath` is not present in the registry, the discovery mechanism will now look for `python3.exe` first, and then fall back to `python.exe` for Python 3, and only `python.exe` for Python 2. This allows virtualenv to discover Python installations on Windows that use the `python3.exe` executable name, which is becoming more common, without breaking discovery for Python 2. A test case has been added to verify this new behavior. chore: Add logging to aid debugging test failures
On Windows, when discovering Python interpreters via PEP 514, if the `ExecutablePath` is not present in the registry, the discovery mechanism will now look for `python3.exe` first, and then fall back to `python.exe` for Python 3, and only `python.exe` for Python 2. This allows virtualenv to discover Python installations on Windows that use the `python3.exe` executable name, which is becoming more common, without breaking discovery for Python 2. A test case has been added to verify this new behavior.
On Windows, when discovering Python interpreters via PEP 514, if the `ExecutablePath` is not present in the registry, the discovery mechanism will now look for `python3.exe` first, and then fall back to `python.exe` for Python 3, and only `python.exe` for Python 2. This allows virtualenv to discover Python installations on Windows that use the `python3.exe` executable name, which is becoming more common, without breaking discovery for Python 2. A test case has been added to verify this new behavior.
Marked this as a draft for now 🚧—let’s get the CI sorted, and then feel free to mark it ready for review! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when discovering Python interpreters via PEP 514, if the
ExecutablePath
is not present in the registry, the discovery mechanism will now look forpython3.exe
first, and then fall back topython.exe
.This allows virtualenv to discover Python on Windows installations that use the
python.exe
executable name.Fixes #2774
tox -e fix
)docs/changelog
folder