feat: Add PKG_CONFIG_PATH to venv activation scripts #2915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for `pkg-config` to virtualenv by adding the virtual environment's `lib/pkgconfig` directory to the `PKG_CONFIG_PATH` environment variable upon activation. This is done for all supported shells: - Bash (`activate.sh`) - Batch (`activate.bat`, `deactivate.bat`) - C Shell (`activate.csh`) - Fish (`activate.fish`) - Nushell (`activate.nu`) - PowerShell (`activate.ps1`) - Python (`activate_this.py`) The implementation follows the style of the existing activation scripts for each shell, saving the original `PKG_CONFIG_PATH` on activation and restoring it on deactivation. Unit tests for each shell's activation have been updated to verify that `PKG_CONFIG_PATH` is set and unset correctly. Fixes pypa#2637
gaborbernat
previously approved these changes
Jul 31, 2025
The activation scripts for bash and fish did not correctly handle the `PKG_CONFIG_PATH` environment variable when it was initially unset. This caused the variable to be set to an empty string after deactivation, instead of being unset. This commit fixes the activation scripts to correctly save and restore the `PKG_CONFIG_PATH`, and adds tests to verify the behavior.
auto-merge was automatically disabled
July 31, 2025 17:42
Head branch was pushed to by a user without write access
The activation scripts for bash, fish, nushell, and powershell did not correctly handle the `PKG_CONFIG_PATH` environment variable when it was initially unset. This caused the variable to be set to an empty string after deactivation, instead of being unset. This commit fixes the activation scripts to correctly save and restore the `PKG_CONFIG_PATH`, and adds tests to verify the behavior. This ensures that the environment is restored to its original state after deactivation.
The activation scripts for bash, fish, nushell, powershell, and batch did not correctly handle the `PKG_CONFIG_PATH` environment variable when it was initially unset. This caused the variable to be set to an empty string after deactivation, instead of being unset. This commit fixes the activation scripts to correctly save and restore the `PKG_CONFIG_PATH`, and adds tests to verify the behavior. This ensures that the environment is restored to its original state after deactivation.
|
Marked this as a draft for now 🚧—let’s get the CI sorted, and then feel free to mark it ready for review! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for
pkg-configto virtualenv by adding the virtual environment'slib/pkgconfigdirectory to thePKG_CONFIG_PATHenvironment variable upon activation.This is done for all supported shells:
activate.sh)activate.bat,deactivate.bat)activate.csh)activate.fish)activate.nu)activate.ps1)activate_this.py)The implementation follows the style of the existing activation scripts for each shell, saving the original
PKG_CONFIG_PATHon activation and restoring it on deactivation.Unit tests for each shell's activation have been updated to verify that
PKG_CONFIG_PATHis set and unset correctly.Fixes #2637
tox -e fix)docs/changelogfolder