Skip to content

Adding custom annotations #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+289 −28
Open

Adding custom annotations #549

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be51dd5
Added support for custom API annotations
azykophus Mar 20, 2025
3e3487e
Update template.go
azykophus Mar 20, 2025
b721988
Update extensions.go
azykophus Mar 20, 2025
6d80ea4
Update extensions_register.go
azykophus Mar 20, 2025
0939748
Update generic.go
azykophus Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update extensions_register.go
  • Loading branch information
@azykophus
azykophus authored Mar 20, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
commit 6d80ea4524eb7e59ca99103614765a26a7324d83
3 changes: 1 addition & 2 deletions extensions/extensions_register.go
View file
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ func registerExtension(ext *protokit.ExtensionDescriptor) {
ExtendedType: extendedType,
ExtensionType: extType,
Field: int32(ext.GetNumber()),
Name: correctFullName, // explicitly correct now
Name: correctFullName,
Tag: generateTag(ext),
})
}
@@ -114,7 +114,6 @@ func determineExtensionType(ext *protokit.ExtensionDescriptor) interface{} {
}
return (*int32)(nil) // single enum represented as *int32
case descriptor.FieldDescriptorProto_TYPE_MESSAGE:
// Skip temporarily, as we discussed before
return nil
default:
panic(fmt.Sprintf("Unsupported extension field type: %s", ext.GetType().String()))