[PHP] add missing reserved words: mixed, never and object #22317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "require"=>0, "require_once"=>0, "return"=>0, "self"=>0, "static"=>0, | ||
| "string"=>0, "switch"=>0, "throw"=>0, "trait"=>0, "true"=>0, | ||
| "try"=>0, "unset"=>0, "use"=>0, "var"=>0, "void"=>0, | ||
| "while"=>0, "xor"=>0, "yield"=>0, |
There was a problem hiding this comment.
For whoever is reviewing it, I noticed that some keys were not alphabetically ordered, being more difficult to find the keywords when checking for it.
Since I was already changing it, I ended up refactoring it to reorder them, hence the bigger change set. Let me know if this is a problem, I can revert it and add the keys to the end only.
The same was done in names.cc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few reserved keywords are missing in the protobuf implementation:
mixed(PHP 8.0)never(PHP 8.1)object(PHP 7.2)They are described in this page: https://www.php.net/manual/en/reserved.other-reserved-words.php.
There should be no breaking changes to the current active versions considering that PHP 7.2 and 8.0 already reached EOL and PHP 8.1 is under security fixes only according to its website: https://www.php.net/supported-versions.php. Any attempt to use those words generates a fatal error in PHP 8.1+.