Skip to content

Warn if configuration file not found, fail if missing auths or modules #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2025
Merged

Warn if configuration file not found, fail if missing auths or modules #1457

merged 1 commit into from
Jul 26, 2025
+30 −13

Conversation

candlerb
Copy link
Contributor

@candlerb candlerb commented Jul 2, 2025 •
edited
Loading

Fixes #1456

(Admittedly it's annoying to have to plumb through a logger just for one message)

@candlerb candlerb force-pushed the candlerb/1456 branch 3 times, most recently from aa59d8f to 6158436 Compare July 2, 2025 12:12
@candlerb
Copy link
Contributor Author

candlerb commented Jul 2, 2025

The test failure for ci/circleci: generator is unrelated to this change.

...
E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/universe/p/p7zip/p7zip_16.02%2bdfsg-8_amd64.deb  Unable to connect to archive.ubuntu.com:http: [IP: 185.125.190.83 80]
E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/universe/p/p7zip/p7zip-full_16.02%2bdfsg-8_amd64.deb  Unable to connect to archive.ubuntu.com:http: [IP: 185.125.190.83 80]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?

@candlerb candlerb mentioned this pull request Jul 2, 2025
Closed
SuperQ
SuperQ reviewed Jul 2, 2025
View reviewed changes
bastischubert
bastischubert approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@bastischubert bastischubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

SuperQ
SuperQ requested changes Jul 26, 2025
View reviewed changes
SuperQ
SuperQ approved these changes Jul 26, 2025
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit 0a4fcda into prometheus:main Jul 26, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

@bastischubert bastischubert bastischubert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing configuration file is silently ignored
3 participants
@candlerb @SuperQ @bastischubert