Updated error message when vault script access is not provided. #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appurva21
reviewed
Jul 3, 2025
| @@ -411,7 +411,8 @@ module.exports = { | |||
| const dispatch = (e, r) => { this.host.dispatch(EXECUTION_VAULT_BASE + executionId, id, e, r); }; | |||
|
|
|||
| if (!hasVaultAccess) { | |||
| return dispatch('Vault access denied'); | |||
| return dispatch('Vault access denied.' + | |||
| ' To allow script access, go to Vault settings and turn on "Enable support in scripts"'); | |||
There was a problem hiding this comment.
@VShingala I understand the motivation, but the updated error message has nothing to do with postman-runtime and is leaking details of the system outside of its domain.
I'd recommend throwing an error with a specific code and then handling it based on the code where ever requied.
There was a problem hiding this comment.
@appurva21 Hmm, That makes sense. Let me figure out if we can do this from parent system where we can override it.
|
Closing this PR for now since it's out of context for this module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the error message provided when vault access is not provided from Postman App while script execution happens.
We're adding extra line to give more meaningful message to help fix the issue.
Error shown after change in App.