Skip to content

FIX: Don't pass ignore and force index to init_fitlins_wf #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

adelavega
Copy link
Collaborator

@adelavega adelavega commented Dec 10, 2019

As it gets handled in the initial layout build

fixes #201

@adelavega
Copy link
Collaborator Author

Let's call this WIP for now, because now I'm getting this error:

         could not run node: fitlins_wf.loader
ERROR:nipype.workflow:could not run node: fitlins_wf.loader
Traceback (most recent call last):
  File "/opt/miniconda-latest/envs/neuro/bin/neuroscout", line 11, in <module>
    load_entry_point('neuroscout-cli', 'console_scripts', 'neuroscout')()
  File "/src/neuroscout/neuroscout_cli/cli.py", line 61, in main
    command(deepcopy(args)).run()
  File "/src/neuroscout/neuroscout_cli/commands/run.py", line 57, in run
    retcode = run_fitlins(fitlins_args)
  File "/opt/miniconda-latest/envs/neuro/lib/python3.6/site-packages/fitlins/cli/run.py", line 265, in run_fitlins
    analysis.setup(**selectors)
  File "/opt/miniconda-latest/envs/neuro/lib/python3.6/site-packages/bids/analysis/analysis.py", line 94, in setup
    b.setup(input_nodes, drop_na=drop_na, **selectors)
  File "/opt/miniconda-latest/envs/neuro/lib/python3.6/site-packages/bids/analysis/analysis.py", line 207, in setup
    **kwargs)
  File "/opt/miniconda-latest/envs/neuro/lib/python3.6/site-packages/bids/layout/layout.py", line 1096, in get_collections
    skip_empty=skip_empty, **kwargs)
  File "/opt/miniconda-latest/envs/neuro/lib/python3.6/site-packages/bids/variables/io.py", line 93, in load_variables
    dataset = _load_time_variables(layout, dataset, scope=scope, **_kwargs)
  File "/opt/miniconda-latest/envs/neuro/lib/python3.6/site-packages/bids/variables/io.py", line 165, in _load_time_variables
    raise ValueError("No functional images that match criteri

@effigies
Copy link
Collaborator

It may be that there was a useful function performed by ignoring on some layouts and not on others...

@codecov-io
Copy link

codecov-io commented Dec 11, 2019

Codecov Report

Merging #202 into master will increase coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
+ Coverage   76.48%   76.78%   +0.29%     
==========================================
  Files          18       18              
  Lines        1029     1025       -4     
  Branches      181      179       -2     
==========================================
  Hits          787      787              
+ Misses        150      148       -2     
+ Partials       92       90       -2
Flag Coverage Δ
#ds003 76.78% <100%> (+0.29%) ⬆️
Impacted Files Coverage Δ
fitlins/workflows/base.py 62.92% <ø> (+2.7%) ⬆️
fitlins/cli/run.py 84.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad0a153...e96fd3e. Read the comment docs.

@adelavega
Copy link
Collaborator Author

Okay, that should take care of it. It was treating ignore as a list, when it was a string.

@effigies effigies merged commit a05b6b0 into poldracklab:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore is missing from LoadBIDSModelInputSpec
3 participants