Skip to content

Implement RTPProcessor #3063 #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arjunshajitech
Copy link
Contributor

@arjunshajitech arjunshajitech commented Mar 13, 2025

This is part 1/2 of a cross-repository series.

Part 2 : pion/webrtc#3064

Description

Replaced RTPReader with RTPprocessor.

Old

BindRemoteStream(info *StreamInfo, reader RTPReader) RTPReader

New

BindRemoteStream(info *StreamInfo, processor RTPProcessor) RTPProcessor

The tight coupling between RTPReader within interceptors prevents RTX packets from passing through the interceptors of the corresponding RTP track.

Reference issue

Fixes #3063

The tight coupling between RTPReader within interceptors prevents RTX packets from passing through the interceptors of the corresponding RTP track.
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 82.81250% with 11 lines in your changes missing coverage. Please review.

Project coverage is 69.82%. Comparing base (73f7ccf) to head (ec36772).

Files with missing lines Patch % Lines
internal/test/mock_stream.go 77.27% 3 Missing and 2 partials ⚠️
chain.go 0.00% 3 Missing ⚠️
pkg/mock/interceptor.go 60.00% 2 Missing ⚠️
pkg/twcc/sender_interceptor.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
- Coverage   71.69%   69.82%   -1.88%     
==========================================
  Files          79       79              
  Lines        4742     4752      +10     
==========================================
- Hits         3400     3318      -82     
- Misses       1203     1282      +79     
- Partials      139      152      +13     
Flag Coverage Δ
go 69.69% <82.81%> (-2.01%) ⬇️
wasm 67.48% <73.43%> (-2.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Pion repeatedly sends the same RTCP (NACK) packet even after successfully receiving and processing the corresponding RTX packet.
1 participant