-
-
Notifications
You must be signed in to change notification settings - Fork 374
Implement Feature Request 1088 #1625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. Added current humidity to state info 2. Added status badge to indicate if humidifier is idle or not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable but I haven't tested on my end
Mostly removing unneeded code and improving readability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you !
Sorry for the late review.
I added a small change : use a different icon if idle. Otherwise it's ok for me 🙂
This PR broke the state info for me. Instead of the humidity %, it now just shows "On ⸱ undefined" |
Description
Implementation of #1088. Specifically:
Related Issue
This PR fixes or closes issue: fixes #1088
Motivation and Context
Makes the humidifier card match features with climate card providing more information to users.
How Has This Been Tested
Tested locally following "developer" instructions.
Types of changes
Checklist