Fix #78374: Warning when closing FTPS connection after FTP_PUT #7362
Conversation
`ftp_ssl_shutdown()` attempts a bidirectional shutdown handshake, i.e. we're sending a close_notify alert, and then wait for the peer to send its close_notify alert. If the peer doesn't sent it, typically because it already closed the connection, we should not raise a warning, but rather ignore this condition.
|
New test fails on azure. |
The latter might not be supported by the OpenSSL library.
|
Thanks! I've pushed a potential fix. |
|
Nope, that wasn't the issue. This may get funny. |
|
Apparently, the test fails only with OpenSSL 1.1, but passes with OpenSSL 1.0. I have no idea why, though. Any hints appreciated! |
|
From the comments above, I cannot conclude what the findings are with regard to the problem. I still get the warning. Apache/2.4.57 (Win64) OpenSSL/1.1.1t PHP/8.3.17. OpenSSL Library Version: OpenSSL 3.0.15 3 Sep 2024. Is this pull request closed, because there is no solution (yet)? Or is there a newer PHP version with a fix? I can't find anything in the PHP version history. Any help would be appreciated. Thanks! |
|
Indeed, this bug has still not been fixed; I had given up on it.
Which OpenSSL version is it, 1.1.1t or 3.0.15? |
|
Sorry for being ambiguous. |
|
In C:\Program Files\Apache Software Foundation\Apache_2.4.57_VS16\bin I have libssl-1_1-x64.dll. (Version 1.1.1t). This file came with Apache. (All my FTP functions work so far, except for this warning.) |
ftp_ssl_shutdown()attempts a bidirectional shutdown handshake, i.e.we're sending a close_notify alert, and then wait for the peer to send
its close_notify alert. If the peer doesn't sent it, typically because
it already closed the connection, we should not raise a warning, but
rather ignore this condition.
Note that the test case is somewhat bogus as it wouldn't fail without the changes to ftp.c; I wouldn't know how to accomplish that. Still, the test case makes some sense on its own, since it tests uploading via FTPS.