Fix GH-15796: Add the exit_status() function
#19445
Open
+68
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
exit-status-func
branch
from
bb9e345 to
3b124ed
Compare
TimWolla
requested changes
Aug 12, 2025
alexandre-daubois
force-pushed
the
exit-status-func
branch
from
3b124ed to
df352ca
Compare
alexandre-daubois
force-pushed
the
exit-status-func
branch
from
df352ca to
22a19ee
Compare
TimWolla
approved these changes
Aug 12, 2025
mvorisek
reviewed
Aug 12, 2025
| @@ -41,6 +41,8 @@ function strncasecmp(string $string1, string $string2, int $length): int {} | |||
|
|
|||
| function error_reporting(?int $error_level = null): int {} | |||
|
|
|||
| function exit_status(): int {} | |||
There was a problem hiding this comment.
Suggested change
| function exit_status(): int {} | |
| function exit_status(): ?int {} |
Would make more sense to indicate we are in shutdown process or not.
There was a problem hiding this comment.
I'm not sure to get your comment. Where/when should this function return null?
There was a problem hiding this comment.
When exit was not called yet.
There was a problem hiding this comment.
When exit is not called yet, the return code of the process will be 0. Also, it can be changed to 255 when an uncaught exception occurs. Thus, I'm not sure this function should return null, because the process will always have an exit code, no matter what.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #15796
Especially useful in shutdown handler, allows to get the current exit status code if set by an exit statement.