Correctly return IP address when using trusted header #16784
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
When using
$this->request->getClientAddress(true);
to extract IP address fromX-Forwarded-For
header it needs to select the first left side IP that is not private or reserved IP address.Added support for users to add their own
trustedProxies
via method, accepts array of IPs or range of IPs.This will trigger an
Exception("The forwarded proxy IP addresses are not trusted.")
if users mess up their proxy setup.Thanks