fix incorrect calibration warnings #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the warnings produced were happening for phalanges which were not calibrated for. We already have the editor warning for that. If no data was collected for a phalange at all, then the "calibration went wrong" shouldn't be fired. This fixes that by ensuring at least one frame with one ray interacted with the relevant phalange
Runtime/Components/ConeRayAnglesEstimator/NthPercentileConeRaySegmnetComputation.cs
Outdated
Show resolved
Hide resolved
ahmed-shariff
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the warnings produced were happening for phalanges which were not calibrated for, and misattributing it to the minimum ray interaction threshold. We already have the editor warning for phalanges which haven't received any data during the calibration phase. If no data was collected for a phalange at all, then the "calibration went wrong" shouldn't be fired. This PR fixes that by ensuring at least one frame with one ray interacted with the relevant phalange before complaining about calibration going incorrect on account of min ray interaction threshold's requirement.