-
Notifications
You must be signed in to change notification settings - Fork 1
Add BDD tests for article content validation and enable test workflow #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: dannystaple <[email protected]>
…ation Co-authored-by: dannystaple <[email protected]>
…validation Co-authored-by: dannystaple <[email protected]>
Co-authored-by: dannystaple <[email protected]>
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
@copilot I've spotted a problem, the tests in .github/workflows/on_pr_test.yaml are only set to run if certain paths are changed. I think removing the on.pull_request.paths item will allow the tests to run in this pr. We can refine and exclude things later if they are irrelevant. |
Co-authored-by: dannystaple <[email protected]>
Fixed! Removed the |
This PR adds comprehensive BDD tests for validating article content and layout, specifically targeting the article at
/2025/07/08/08-comparing-anker-power-packs.html
, and fixes the GitHub Actions workflow to ensure the tests can run on pull requests.What's Added
BDD Test Suite:
tests/staging/features/article-content.feature
with two scenarios:Enhanced Step Definitions:
tests/staging/step_definitions/website_steps.js
Workflow Fix:
paths
restriction from.github/workflows/on_pr_test.yaml
to allow BDD tests to run on all PRs instead of being limited to specific file pathsTest Coverage
The tests validate all requirements from the original issue:
/tags/robotics-at-home
,/tags/raspberry-pi
, etc.)<article>
tag with valid src attributes (7 images found)Usage
Run the BDD tests using Docker:
docker compose run test
The tests use the existing Cucumber.js + Playwright framework and follow the same patterns as other tests in the repository.
Fixes #262.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.