Skip to content

Sync with internal repo #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 21, 2025
Merged

Sync with internal repo #127

merged 11 commits into from
Apr 21, 2025

Conversation

piyush-tiwari
Copy link
Member

Commits added:

  1. Allow certificates to be managed in LB compartment
  2. Preserve defined tags on LB when defined-tag related annotations are absent
  3. Only sync relevant BackendSets and Listeners for an Ingress reconciliation
  4. Report warning events for ingress and ingressclass reconciliation failures
  5. Allow host header to contain listener port for routing rules
  6. Make tlsv1.2 minimum for webhook server
  7. Clean up unused certificate resources managed by NIC
  8. Bump golang.org/x/net to 0.36.0, golang.org/x/oauth2 to 0.27.0, go compile version to 1.23.7
  9. Doc update for v1.4.2

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 14, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 14439428823

Details

  • 418 of 646 (64.71%) changed or added relevant lines in 18 files are covered.
  • 10 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-5.1%) to 61.516%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/ingressclass/ingressclass.go 7 10 70.0%
pkg/controllers/routingpolicy/util.go 7 10 70.0%
pkg/exception/util.go 10 13 76.92%
pkg/oci/client/certificatemanagement.go 0 3 0.0%
pkg/controllers/routingpolicy/routingpolicy.go 5 11 45.45%
pkg/util/publish_event_util.go 20 30 66.67%
pkg/controllers/ingress/ingress.go 31 43 72.09%
pkg/controllers/nodeBackend/nodeBackend.go 23 35 65.71%
pkg/controllers/backend/backend.go 31 45 68.89%
pkg/task/certificatecleanup/util.go 162 176 92.05%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/ingress/ingress.go 1 55.81%
pkg/controllers/nodeBackend/nodeBackend.go 1 64.75%
pkg/controllers/routingpolicy/util.go 1 88.61%
pkg/util/util.go 1 61.2%
pkg/certificate/certificate.go 2 65.24%
pkg/controllers/ingressclass/ingressclass.go 2 59.76%
pkg/controllers/routingpolicy/routingpolicy.go 2 33.5%
Totals Coverage Status
Change from base Build 13450495497: -5.1%
Covered Lines: 3312
Relevant Lines: 5384

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 14, 2025

Pull Request Test Coverage Report for Build 14567925828

Details

  • 467 of 646 (72.29%) changed or added relevant lines in 17 files are covered.
  • 10 unchanged lines in 7 files lost coverage.
  • Overall coverage increased (+0.4%) to 66.937%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/ingressclass/ingressclass.go 7 10 70.0%
pkg/controllers/routingpolicy/util.go 7 10 70.0%
pkg/controllers/routingpolicy/routingpolicy.go 5 11 45.45%
pkg/util/publish_event_util.go 20 30 66.67%
pkg/controllers/ingress/ingress.go 31 43 72.09%
pkg/controllers/nodeBackend/nodeBackend.go 23 35 65.71%
pkg/controllers/backend/backend.go 31 45 68.89%
pkg/task/certificatecleanup/util.go 162 176 92.05%
pkg/util/util.go 32 62 51.61%
pkg/task/certificatecleanup/certificate_cleanup.go 72 104 69.23%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/ingress/ingress.go 1 55.81%
pkg/controllers/nodeBackend/nodeBackend.go 1 64.75%
pkg/controllers/routingpolicy/util.go 1 88.61%
pkg/util/util.go 1 61.2%
pkg/certificate/certificate.go 2 65.24%
pkg/controllers/ingressclass/ingressclass.go 2 59.76%
pkg/controllers/routingpolicy/routingpolicy.go 2 33.5%
Totals Coverage Status
Change from base Build 13450495497: 0.4%
Covered Lines: 3387
Relevant Lines: 5060

💛 - Coveralls

@piyush-tiwari piyush-tiwari force-pushed the dev-piytiwar branch 2 times, most recently from 7823607 to 2110344 Compare April 14, 2025 14:03
@piyush-tiwari piyush-tiwari merged commit 6dbeef1 into main Apr 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants