Skip to content

CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs #15254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Jul 7, 2025

changes:

As a part of the CodeEditor update to use entirely CodeEditorControls, the "Ask OpenShift Lightspeed" button in the code editor has shrunk to match the design. I also designed some show/hide sidebar icons to replace the switch that existed there before

Screencast.From.2025-07-07.17-09-31.mp4

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2025

@logonoff: This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

changes:

  • Added a copy to clipboard button
  • Added fullscreen button
  • Added ability to toggle sticky scroll
  • Refactored edit-yaml to typescript
Screencast.From.2025-07-07.10-58-38.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2025

@logonoff: This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

changes:

  • Added a copy to clipboard button
  • Added fullscreen button
  • Added ability to toggle sticky scroll
  • Refactored edit-yaml to typescript
Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and jhadvig July 7, 2025 21:11
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2025

@logonoff: This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

changes:

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jul 8, 2025
@logonoff logonoff force-pushed the CONSOLE-4499-codeeditor-electric-boogaloo branch from f5153b8 to 412fcf8 Compare July 8, 2025 15:11
@logonoff logonoff force-pushed the CONSOLE-4499-codeeditor-electric-boogaloo branch from 412fcf8 to b8a275b Compare July 8, 2025 15:31
@logonoff logonoff changed the title CONSOLE-4499: Implement some CodeEditor RFEs (WIP) CONSOLE-4499, CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs (WIP) Jul 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2025

@logonoff: This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

changes:

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff changed the title CONSOLE-4499, CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs (WIP) CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs (WIP) Jul 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2025

@logonoff: This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

changes:

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the CONSOLE-4499-codeeditor-electric-boogaloo branch from 218e928 to 0c4b0ed Compare July 8, 2025 19:36
@logonoff
Copy link
Member Author

logonoff commented Jul 8, 2025

code review:
/assign @rhamilto

qe review:
/assign @yapei

px approval:
/assign @sferich888

docs approval:
/assign @opayne1

Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff logonoff changed the title CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs (WIP) CONSOLE-4656, CONSOLE-4499, CONSOLE-4654, CONSOLE-4657: Implement some CodeEditor RFEs Jul 9, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2025

@logonoff: This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

changes:

As a part of the CodeEditor update to use entirely CodeEditorControls, the "Ask OpenShift Lightspeed" button in the code editor has shrunk to match the design. I also designed some show/hide sidebar icons to replace the switch that existed there before

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2025

@logonoff: This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

changes:

As a part of the CodeEditor update to use entirely CodeEditorControls, the "Ask OpenShift Lightspeed" button in the code editor has shrunk to match the design. I also designed some show/hide sidebar icons to replace the switch that existed there before

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2025

@logonoff: This pull request references CONSOLE-4656 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4499 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4654 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

This pull request references CONSOLE-4657 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

changes:

As a part of the CodeEditor update to use entirely CodeEditorControls, the "Ask OpenShift Lightspeed" button in the code editor has shrunk to match the design. I also designed some show/hide sidebar icons to replace the switch that existed there before

Screencast.From.2025-07-07.17-09-31.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants