Skip to content

CONSOLE-4653: Allow custom icons in template annotation #15248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Jul 7, 2025

addresses #15216, https://issues.redhat.com/browse/RFE-1125, and https://issues.redhat.com/browse/CONSOLE-4653

Template authors can now enter URLs pointing to images in the iconClass annotation to show a custom icon.

after:

image
image

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2025

@logonoff: This pull request references CONSOLE-4653 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

addresses #15216, https://issues.redhat.com/browse/RFE-1125, and https://issues.redhat.com/browse/RFE-1125

Template authors can now enter URLs to images in the iconClass annotation to show a custom icon.

after:

image
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2025

@logonoff: This pull request references CONSOLE-4653 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

addresses #15216, https://issues.redhat.com/browse/RFE-1125, and https://issues.redhat.com/browse/RFE-1125

Template authors can now enter URLs pointing to images in the iconClass annotation to show a custom icon.

after:

image
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jul 7, 2025
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/dev-console Related to dev-console approved Indicates a PR has been approved by an approver from all required OWNERS files. component/shared Related to console-shared labels Jul 7, 2025
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

@logonoff: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console 4063b6c link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2025

@logonoff: This pull request references CONSOLE-4653 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

addresses #15216, https://issues.redhat.com/browse/RFE-1125, and https://issues.redhat.com/browse/CONSOLE-4653

Template authors can now enter URLs pointing to images in the iconClass annotation to show a custom icon.

after:

image
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig jhadvig requested a review from vikram-raj July 8, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants