Skip to content

OCPBUGS-57392: Update guided tour modal and add a image #15245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vikram-raj
Copy link
Member

Fixes: https://issues.redhat.com/browse/OCPBUGS-57392

  • Re-arrange Help menus
image
  • Admin perspective guided tour
image
  • Developer perspective guided tour
image

@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dev-console Related to dev-console labels Jul 7, 2025
Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2025
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jul 7, 2025
@vikram-raj
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vikram-raj: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

@vikram-raj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vikram-raj vikram-raj changed the title OCPBUGS 57392: Update guided tour modal and add a image OCPBUGS-57392: Update guided tour modal and add a image Jul 8, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 8, 2025
@openshift-ci-robot
Copy link
Contributor

@vikram-raj: This pull request references Jira Issue OCPBUGS-57392, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes: https://issues.redhat.com/browse/OCPBUGS-57392

  • Re-arrange Help menus
image
  • Admin perspective guided tour
image
  • Developer perspective guided tour
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sanketpathak July 8, 2025 05:12
Comment on lines +13 to +17
<p>
{t(
'console-app~Introducing a fresh modern look to the console with OpenShift 4.19. With this update we have made changes to the user interface to enhance usability and streamline your workflow. This includes an improved navigation and visual refinement aimed at making it easier to manage your applications and infrastructure.',
)}
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Suggested change
<p>
{t(
'console-app~Introducing a fresh modern look to the console with OpenShift 4.19. With this update we have made changes to the user interface to enhance usability and streamline your workflow. This includes an improved navigation and visual refinement aimed at making it easier to manage your applications and infrastructure.',
)}
</p>
<Content component={ContentVariants.p}>
{t(
'console-app~Introducing a fresh modern look to the console with OpenShift 4.19. With this update we have made changes to the user interface to enhance usability and streamline your workflow. This includes an improved navigation and visual refinement aimed at making it easier to manage your applications and infrastructure.',
)}
</Content>

Comment on lines +18 to +20
<Content component={ContentVariants.h6}>
{t('console-app~What do you want to do next?')}
</Content>
Copy link
Member

@logonoff logonoff Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this part as the ODC tour doesn't have it

Suggested change
<Content component={ContentVariants.h6}>
{t('console-app~What do you want to do next?')}
</Content>

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per UX it is needed.

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we pick a new illustration that has a background colour matching the UI

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logonoff Yeah for sure!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these Red Hat branded illustrations also usually have a dark mode variant. should we be showing the dark mode variant in dark mode?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants