-
Notifications
You must be signed in to change notification settings - Fork 647
ODC-7803: Add custom icons in import flow #15242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@logonoff: This pull request references ODC-7803 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
docs review: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@logonoff: This pull request references ODC-7803 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/hold UI is WIP and pending testing and refinement |
933dff0
to
a20d9a3
Compare
d994a43
to
c191419
Compare
@logonoff: This pull request references ODC-7803 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ux review: |
c191419
to
f0499ec
Compare
f0499ec
to
5700323
Compare
/label docs-approved |
5700323
to
4f001ee
Compare
@logonoff: This pull request references ODC-7803 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@logonoff: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
addresses https://issues.redhat.com/browse/ODC-7803 and https://issues.redhat.com/browse/RFE-5057
This PR introduces a new annotation for Deployments and DeploymentConfigs:
app.openshift.io/custom-icon
This annotation comprises a valid URI pointing to an image that the browser can parse.
When an icon is uploaded, the icon is stored as a base64-encoded data URI. Due to annotation size restrictions in kubernetes, this means uploaded icons have a heavily restricted maximum file size.
Icons should have a transparent background and should be provided in an 1:1 aspect ratio to ensure proper rendering, however this is not validated against.
This annotation takes precedence over the
app.openshift.io/runtime
label when deciding which icon to render.Screencast.From.2025-07-07.10-58-38.mp4