Skip to content

ODC-7803: Add custom icons in import flow #15242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

logonoff
Copy link
Member

@logonoff logonoff commented Jul 4, 2025

addresses https://issues.redhat.com/browse/ODC-7803 and https://issues.redhat.com/browse/RFE-5057

This PR introduces a new annotation for Deployments and DeploymentConfigs: app.openshift.io/custom-icon

This annotation comprises a valid URI pointing to an image that the browser can parse.

When an icon is uploaded, the icon is stored as a base64-encoded data URI. Due to annotation size restrictions in kubernetes, this means uploaded icons have a heavily restricted maximum file size.

Icons should have a transparent background and should be provided in an 1:1 aspect ratio to ensure proper rendering, however this is not validated against.

This annotation takes precedence over the app.openshift.io/runtime label when deciding which icon to render.

Screencast.From.2025-07-07.10-58-38.mp4

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 4, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 4, 2025

@logonoff: This pull request references ODC-7803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

addresses https://issues.redhat.com/browse/ODC-7803

This PR introduces a new annotation for Deployments and DeploymentConfigs: app.openshift.io/custom-icon

This annotation comprises a valid URI pointing to an image that the browser can parse. This annotation takes precedence over the app.openshift.io/runtime label when deciding which icon to render.

Screencast.From.2025-07-04.13-23-50.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jul 4, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@logonoff
Copy link
Member Author

logonoff commented Jul 4, 2025

docs review:
/assign @opayne1

@openshift-ci openshift-ci bot added the component/dev-console Related to dev-console label Jul 4, 2025
Copy link
Contributor

openshift-ci bot commented Jul 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/shared Related to console-shared approved Indicates a PR has been approved by an approver from all required OWNERS files. component/topology Related to topology labels Jul 4, 2025
@logonoff logonoff marked this pull request as ready for review July 4, 2025 17:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 4, 2025
@openshift-ci openshift-ci bot requested review from kyoto and lokanandaprabhu July 4, 2025 17:33
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 4, 2025

@logonoff: This pull request references ODC-7803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

addresses https://issues.redhat.com/browse/ODC-7803

This PR introduces a new annotation for Deployments and DeploymentConfigs: app.openshift.io/custom-icon

This annotation comprises a valid URI pointing to an image that the browser can parse.

When an icon is uploaded, the icon is stored as a base64-encoded data URI. Due to annotation size restrictions in kubernetes, this means uploaded icons have a heavily restricted maximum file size.

Icons should have a transparent background and should be provided in an 1:1 aspect ratio to ensure proper rendering, however this is not validated against.

This annotation takes precedence over the app.openshift.io/runtime label when deciding which icon to render.

Screencast.From.2025-07-04.13-23-50.webm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

logonoff commented Jul 4, 2025

/hold

UI is WIP and pending testing and refinement

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025
@logonoff logonoff force-pushed the ODC-7803-custom-icons branch from 933dff0 to a20d9a3 Compare July 4, 2025 23:54
@openshift-ci openshift-ci bot added the kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated label Jul 4, 2025
@logonoff logonoff force-pushed the ODC-7803-custom-icons branch 5 times, most recently from d994a43 to c191419 Compare July 7, 2025 14:38
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2025

@logonoff: This pull request references ODC-7803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

addresses https://issues.redhat.com/browse/ODC-7803

This PR introduces a new annotation for Deployments and DeploymentConfigs: app.openshift.io/custom-icon

This annotation comprises a valid URI pointing to an image that the browser can parse.

When an icon is uploaded, the icon is stored as a base64-encoded data URI. Due to annotation size restrictions in kubernetes, this means uploaded icons have a heavily restricted maximum file size.

Icons should have a transparent background and should be provided in an 1:1 aspect ratio to ensure proper rendering, however this is not validated against.

This annotation takes precedence over the app.openshift.io/runtime label when deciding which icon to render.

Screencast.From.2025-07-07.10-58-38.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff
Copy link
Member Author

logonoff commented Jul 7, 2025

ux review:
/assign @kevinhatchoua @andrew-ronaldson

@logonoff logonoff force-pushed the ODC-7803-custom-icons branch from f0499ec to 5700323 Compare July 7, 2025 15:19
@opayne1
Copy link
Contributor

opayne1 commented Jul 7, 2025

/label docs-approved

@logonoff logonoff force-pushed the ODC-7803-custom-icons branch from 5700323 to 4f001ee Compare July 7, 2025 15:20
@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 7, 2025

@logonoff: This pull request references ODC-7803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

addresses https://issues.redhat.com/browse/ODC-7803 and https://issues.redhat.com/browse/RFE-5057

This PR introduces a new annotation for Deployments and DeploymentConfigs: app.openshift.io/custom-icon

This annotation comprises a valid URI pointing to an image that the browser can parse.

When an icon is uploaded, the icon is stored as a base64-encoded data URI. Due to annotation size restrictions in kubernetes, this means uploaded icons have a heavily restricted maximum file size.

Icons should have a transparent background and should be provided in an 1:1 aspect ratio to ensure proper rendering, however this is not validated against.

This annotation takes precedence over the app.openshift.io/runtime label when deciding which icon to render.

Screencast.From.2025-07-07.10-58-38.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jul 7, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@logonoff logonoff changed the title ODC-7803: Add custom icons in import flow (WIP) ODC-7803: Add custom icons in import flow Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/shared Related to console-shared component/topology Related to topology do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants