Skip to content

CONSOLE-4527: Fix type errors arising after turning StrictNullChecks to 'true' #15235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krishagarwal278
Copy link
Contributor

@krishagarwal278 krishagarwal278 commented Jul 3, 2025

Total Number of Errors in a particular directory:
npx tsc --noEmit | wc -l

1400+ type errors fixed: total errors stand at 11,960

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 3, 2025

@krishagarwal278: This pull request references CONSOLE-4527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set.

In response to this:

Total Number of Errors in a particular directory:
npx tsc --noEmit | wc -l

1800+ type errors fixed: total errors stand at 11,960

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 3, 2025

@krishagarwal278: This pull request references CONSOLE-4527 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set.

In response to this:

Total Number of Errors in a particular directory:
npx tsc --noEmit | wc -l

1400+ type errors fixed: total errors stand at 11,960

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Mylanos and rawagner July 3, 2025 05:24
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Jul 3, 2025
Copy link
Contributor

openshift-ci bot commented Jul 3, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: krishagarwal278
Once this PR has been reviewed and has the lgtm label, please assign mylanos for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added component/dashboard Related to dashboard component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/sdk Related to console-plugin-sdk labels Jul 3, 2025
@openshift-ci openshift-ci bot added the component/shared Related to console-shared label Jul 3, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 3, 2025
Copy link
Contributor

openshift-ci bot commented Jul 3, 2025

@krishagarwal278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn fb3defa link false /test okd-scos-e2e-aws-ovn
ci/prow/frontend fb3defa link true /test frontend
ci/prow/images fb3defa link true /test images
ci/prow/analyze fb3defa link true /test analyze
ci/prow/e2e-gcp-console fb3defa link true /test e2e-gcp-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to console core functionality component/dashboard Related to dashboard component/metal3 Related to metal3-plugin component/monitoring Related to monitoring component/sdk Related to console-plugin-sdk component/shared Related to console-shared jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants