OCPBUGS-58050: fix missing form styles in storage pages

[rhamilto]

Follow on fix for #15205 that was not part of the original bug.

The change to RestorePVCModal is untested as I don't know how to configure that so it shows up. @yanpzhan, can you help?

After

Bonus fix to Add Storage page heading:
Note: PatternFly does not provide a mechanism to have different font sizes in headings, so all heading text is the same size now

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-58050, which is invalid:

• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Follow on fix for #15205 that was not part of the original bug.

After

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

/cherry-pick release-4.19
/assign @logonoff

[openshift-cherrypick-robot]

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19
/assign @logonoff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[logonoff]

/lgtm

[rhamilto]

/hold

I believe there is more to do here.

[rhamilto]

/unhold

[rhamilto]

/jira refresh

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-58050, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yanpzhan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamilto]

/retest

[yanpzhan]

@rhamilto the RestorePVCModal is used on a VolumeSnapshot action list. You can create a VolumeSnapshot(first prepare a bound pvc), then open 'Restore as new PVC' in its action list.

[rhamilto]

@rhamilto the RestorePVCModal is used on a VolumeSnapshot action list. You can create a VolumeSnapshot(first prepare a bound pvc), then open 'Restore as new PVC' in its action list.

Thanks! Do you have steps to reproduce? I couldn't get the menu action to enable.

[yanpzhan]

@rhamilto Do you have default StorageClass on your cluster?
You need create a PersistentVolumeClaim from 'Storage'->'Create PersistentVolumeClaims' page based on existing StorageClass, if the PersistentVolumeClaim is not bound, add it to a deployment(using Add Storage in deployment action list), then the PersistentVolumeClaim will be bound.
Go to 'Storage'->'VolumeSnapshots' to create VolumeSnapshot, choose a PersistentVolumeClaim in bound status for field 'PersistentVolumeClaim'. Then the 'Restore as new PVC' item will be enabled in the VolumeSnapshot action list.

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0653c05 and 2 for PR HEAD a52acf8 in total

[logonoff]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0653c05 and 2 for PR HEAD 24833a9 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 0653c05 and 2 for PR HEAD 24833a9 in total

[rhamilto]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c3ea9fa and 1 for PR HEAD 24833a9 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1a34135 and 0 for PR HEAD 24833a9 in total

[openshift-ci-robot]

/hold

Revision 24833a9 was retested 3 times: holding

[rhamilto]

@logonoff, I pushed changes as I was seeing linting issues. Please retag.

[logonoff]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhamilto]

/unhold

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 22549b0 and 2 for PR HEAD 80a45a6 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 716d88c and 2 for PR HEAD 80a45a6 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD cbb54b0 and 1 for PR HEAD 80a45a6 in total

[openshift-ci]

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@rhamilto: Jira Issue OCPBUGS-58050: All pull requests linked via external trackers have merged:

• openshift/console#15205
• openshift/console#15229

Jira Issue OCPBUGS-58050 has been moved to the MODIFIED state.

In response to this:

Follow on fix for #15205 that was not part of the original bug.

The change to RestorePVCModal is untested as I don't know how to configure that so it shows up. @yanpzhan, can you help?

After

Bonus fix to Add Storage page heading:
Note: PatternFly does not provide a mechanism to have different font sizes in headings, so all heading text is the same size now

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@rhamilto: new pull request created: #15258

In response to this:

/cherry-pick release-4.19
/assign @logonoff

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.