OCPBUGS-179: fix conditional edge for type always

[PratikMahajan]

conditional edge has an empty promql when the type of
conditional block is Always
This commit skips the serlialization if promql if the
promql condition is empty, which is the case for
type Always

Co-Authored-By: W. Trevor King [email protected]

[openshift-ci-robot]

@PratikMahajan: This pull request references [Jira Issue OCPBUGS-179](https://issues.redhat.com//browse/OCPBUGS-179), which is invalid:

• expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

conditional edge has an empty promql when the type of
conditional block is Always
This commit skips the serlialization if promql if the
promql condition is empty, which is the case for
type Always

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@PratikMahajan: This pull request references [Jira Issue OCPBUGS-179](https://issues.redhat.com//browse/OCPBUGS-179), which is invalid:

• expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

conditional edge has an empty promql when the type of
conditional block is Always
This commit skips the serlialization if promql if the
promql condition is empty, which is the case for
type Always

Co-Authored-By: W. Trevor King [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wking]

if we leave this unpopulated, what happens?

[PratikMahajan]

using Default:default() for Always condition

[wking]

/lgtm

[PratikMahajan]

/jira refresh

[openshift-ci-robot]

@PratikMahajan: This pull request references [Jira Issue OCPBUGS-179](https://issues.redhat.com//browse/OCPBUGS-179), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.0) matches configured target version for branch (4.12.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

/retest-required

Remaining retests: 2 against base HEAD b55a6ce and 8 for PR HEAD f9db3fe in total

[PratikMahajan]

/retest

[openshift-ci-robot]

/retest-required

Remaining retests: 1 against base HEAD b55a6ce and 7 for PR HEAD f9db3fe in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD b55a6ce and 6 for PR HEAD f9db3fe in total

[wking]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PratikMahajan, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [PratikMahajan,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[PratikMahajan]

/override ci/prow/e2e

Will be fixed in #719

[openshift-ci]

@PratikMahajan: Overrode contexts on behalf of PratikMahajan: ci/prow/e2e

In response to this:

/override ci/prow/e2e

Will be fixed in #719

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@PratikMahajan: All pull requests linked via external trackers have merged:

• openshift/cincinnati#730

[Jira Issue OCPBUGS-179](https://issues.redhat.com//browse/OCPBUGS-179) has been moved to the MODIFIED state.

In response to this:

conditional edge has an empty promql when the type of
conditional block is Always
This commit skips the serlialization if promql if the
promql condition is empty, which is the case for
type Always

Co-Authored-By: W. Trevor King [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@PratikMahajan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e	297f59c	link	unknown	/test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.