Skip to content

feat: adding validation for java & go #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

feat: adding validation for java & go #294

merged 1 commit into from
Jul 17, 2024

Conversation

d-jeffery
Copy link
Contributor

@d-jeffery d-jeffery commented Jul 15, 2024 •
edited
Loading

  • Changed JS Validate object -> Validator
  • Added validation & testing for java
  • Added validation & testing for go

Description

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@d-jeffery d-jeffery force-pushed the feat/java-tuple-validation branch 2 times, most recently from 4b2958a to 8d6e1c2 Compare July 15, 2024 23:27
@d-jeffery d-jeffery requested review from rhamzeh and ewanharris July 15, 2024 23:29
@d-jeffery d-jeffery marked this pull request as ready for review July 15, 2024 23:29
@d-jeffery d-jeffery requested review from a team as code owners July 15, 2024 23:29
@d-jeffery d-jeffery force-pushed the feat/java-tuple-validation branch 4 times, most recently from 70287a8 to fde6366 Compare July 16, 2024 16:36
rhamzeh
rhamzeh reviewed Jul 17, 2024
View reviewed changes
@d-jeffery d-jeffery force-pushed the feat/java-tuple-validation branch from fde6366 to 017d8d9 Compare July 17, 2024 13:28
@d-jeffery d-jeffery force-pushed the feat/java-tuple-validation branch from 017d8d9 to 2664308 Compare July 17, 2024 13:33
@d-jeffery d-jeffery requested a review from rhamzeh July 17, 2024 13:50
@d-jeffery d-jeffery added this pull request to the merge queue Jul 17, 2024
Merged via the queue into main with commit 185709d Jul 17, 2024
18 checks passed
@d-jeffery d-jeffery deleted the feat/java-tuple-validation branch July 17, 2024 16:25
@rhamzeh rhamzeh mentioned this pull request Sep 6, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

@ewanharris ewanharris Awaiting requested review from ewanharris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-jeffery @rhamzeh