Add more app details #2346

[thompson-tomo]

Fixes #2346

Changes

Adds in functionality to record the details of the app which the telemetry is coming from to enable support for non service based scenarios ie Android App.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

• CONTRIBUTING.md guidelines followed.
• Change log entry added, according to the guidelines in When to add a changelog entry.
  • If your PR does not need a change log, start the PR title with [chore]
• schema-next.yaml updated with changes to existing conventions.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 7 days.

[thompson-tomo]

Awaiting review

[LikeTheSalad]

It seems to me that app.name and app.version are duplicates of service.name and service.version values.

[thompson-tomo]

In some cases they will be the same however in other cases they will differ.

For instance you could have a server application which is comprised of multiple services, app provides a way to group the services into a versioned bundle.

[LikeTheSalad]

I know that this term is important for Android apps, although I don't see the value elsewhere. If we want it, it's probably better to put it into an android-specific namespace. WRT the app namespace, it seems to me that app.id makes more sense for different platforms.

[thompson-tomo]

The namespace is designed to be a Grouping of apps similar to how it is used elsewhere.

An example would be if a product had both server & client apps, the app namespace would refer to the product hence shared across all apps.

[breedx-splk]

Hey @thompson-tomo
There is a LOT lot lot of history around using service vs. app for client/mobile applications. And when I say a LOT, I mean an excessively long and drawn out history. On the client/mobile side, we have long ago conceded and agreed to use service.name (and friends) instead of having explicit app.* equivalents.

Please see this PR and all of the related content linked from there: #630

[thompson-tomo]

@breedx-splk this doesn't change that, a service is still what is used to describe what is generating the telemetry. An app is 1 or more service's bundled together into an independently versioned package.

[breedx-splk]

@breedx-splk this doesn't change that, a service is still what is used to describe what is generating the telemetry. An app is 1 or more service's bundled together into an independently versioned package.

Oh interesting. Well, that's not what we've previously considered to be an "app"... so it would appear that you're trying to completely redefine something that we have already established. Look at line 14 of app.md where it clearly says:

An app used directly by end users — like mobile, web, or desktop.

I don't think we want to change that.

[thompson-tomo]

No I am not redefining it, if you install a desktop application ie visual studio 2022 that would be considered 1 app. That app is made up of multiple services. The same is the case for web apps where you might have a frontend & backend services but it should still be considered 1 app.