-
Notifications
You must be signed in to change notification settings - Fork 253
More informative container runtime #2342 #2407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lmolkova
merged 5 commits into
open-telemetry:main
from
thompson-tomo:feature/#2342_ContainerRuntime
Aug 8, 2025
Merged
More informative container runtime #2342 #2407
lmolkova
merged 5 commits into
open-telemetry:main
from
thompson-tomo:feature/#2342_ContainerRuntime
Aug 8, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79fbfdc
to
6cf4b6e
Compare
ChrsMark
reviewed
Jul 1, 2025
a264a42
to
d21ccf2
Compare
ChrsMark
reviewed
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Please register the change in the non-normative k8s migration guidance.
91d1df5
to
9be5dcd
Compare
ChrsMark
approved these changes
Jul 2, 2025
jinja2
reviewed
Jul 2, 2025
0d8a22d
to
e837f37
Compare
8e86e76
to
0831725
Compare
Signed-off-by: James Thompson <[email protected]>
Signed-off-by: James Thompson <[email protected]>
Signed-off-by: James Thompson <[email protected]>
Co-authored-by: Jina Jain <[email protected]>
0831725
to
cf143e8
Compare
lmolkova
reviewed
Aug 1, 2025
jsuereth
approved these changes
Aug 4, 2025
jinja2
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2342
Changes
This converts the
container.runtime
attribute to be a sub-namespace so that the version & description of the runtime can also be supplied.Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]