Skip to content

More informative container runtime #2342 #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thompson-tomo
Copy link
Contributor

@thompson-tomo thompson-tomo commented Jun 21, 2025

Fixes #2342

Changes

This converts the container.runtime attribute to be a sub-namespace so that the version & description of the runtime can also be supplied.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@thompson-tomo thompson-tomo force-pushed the feature/#2342_ContainerRuntime branch from a264a42 to d21ccf2 Compare July 2, 2025 02:21
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Please register the change in the non-normative k8s migration guidance.

@thompson-tomo thompson-tomo requested a review from a team as a code owner July 2, 2025 08:04
@thompson-tomo thompson-tomo force-pushed the feature/#2342_ContainerRuntime branch from 91d1df5 to 9be5dcd Compare July 2, 2025 08:05
@thompson-tomo thompson-tomo requested a review from ChrsMark July 2, 2025 08:07
@thompson-tomo thompson-tomo requested a review from jinja2 July 2, 2025 11:45
@thompson-tomo thompson-tomo force-pushed the feature/#2342_ContainerRuntime branch from 0d8a22d to e837f37 Compare July 7, 2025 05:31
@thompson-tomo thompson-tomo force-pushed the feature/#2342_ContainerRuntime branch 3 times, most recently from 8e86e76 to 0831725 Compare July 21, 2025 03:42
@thompson-tomo thompson-tomo force-pushed the feature/#2342_ContainerRuntime branch from 0831725 to cf143e8 Compare August 1, 2025 09:17
@lmolkova lmolkova moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Aug 1, 2025
@lmolkova lmolkova added this pull request to the merge queue Aug 8, 2025
Merged via the queue into open-telemetry:main with commit 15f0d88 Aug 8, 2025
16 checks passed
@thompson-tomo thompson-tomo deleted the feature/#2342_ContainerRuntime branch August 9, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Extended details about container runtime
5 participants