Skip to content

Automate schema-next generation in release workflow #2307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

Automate schema-next generation in release workflow #2307

merged 2 commits into from
Jul 11, 2025

Conversation

lmolkova
Copy link
Contributor

Fixes #1426

This PR automates schema-next generation. Proposed process changes:

  • schema-next.yaml is deleted, PR authors should not update it
  • reviewers should review deprecated property - it has to be structured and should use proper reason. Only renamed on attributes and metrics is included into generated schema-next.
  • schemas/$version is generated only at the release time using weaver diff

@lmolkova lmolkova requested review from a team as code owners May 28, 2025 20:09
@lmolkova lmolkova force-pushed the automate-schema-next branch from a1f9ce5 to 9067bd3 Compare May 28, 2025 20:27
@lmolkova lmolkova added the Skip Changelog Label to skip the changelog check label May 28, 2025
This was referenced May 29, 2025
Open
Open
Open
jsuereth
jsuereth approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to clarify some limitations, but this looks like a huge improvement for us.

@jsuereth jsuereth moved this from Untriaged to Needs More Approval in Semantic Conventions Triage Jun 5, 2025
@lmolkova lmolkova mentioned this pull request Jun 8, 2025
Open
lmolkova
lmolkova commented Jun 8, 2025
View reviewed changes
@lmolkova lmolkova moved this from Needs More Approval to Blocked in Semantic Conventions Triage Jun 8, 2025
@lmolkova
Copy link
Contributor Author

lmolkova commented Jun 8, 2025

blocked on open-telemetry/weaver#776

@github-actions GitHub Actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 24, 2025
@lmolkova lmolkova moved this from Blocked to Needs More Approval in Semantic Conventions Triage Jun 27, 2025
@lmolkova
Copy link
Contributor Author

lmolkova commented Jun 27, 2025 •
edited
Loading

Now blocked on #2444 (weaver version update)

@lmolkova lmolkova moved this from Needs More Approval to Blocked in Semantic Conventions Triage Jun 27, 2025
@github-actions github-actions bot removed the Stale label Jun 28, 2025
@trask trask modified the milestone: v1.35.0 Jun 30, 2025
@lmolkova lmolkova force-pushed the automate-schema-next branch from b64c2fc to 9275339 Compare July 2, 2025 21:41
@lmolkova lmolkova requested a review from a team as a code owner July 2, 2025 21:41
@lmolkova lmolkova mentioned this pull request Jul 3, 2025
Draft
@lmolkova lmolkova moved this from Blocked to Needs More Approval in Semantic Conventions Triage Jul 5, 2025
@lmolkova lmolkova force-pushed the automate-schema-next branch from 76cb5ab to f40b0aa Compare July 5, 2025 17:35
@lmolkova lmolkova force-pushed the automate-schema-next branch from dcd406e to 62d046a Compare July 5, 2025 17:39
@lmolkova lmolkova enabled auto-merge July 11, 2025 01:49
@lmolkova lmolkova added this pull request to the merge queue Jul 11, 2025
Merged via the queue into open-telemetry:main with commit 0c4e76a Jul 11, 2025
22 checks passed
@lmolkova lmolkova deleted the automate-schema-next branch July 11, 2025 01:51
@lmolkova lmolkova mentioned this pull request Jul 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuereth jsuereth jsuereth approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

Assignees
No one assigned
Labels
Skip Changelog Label to skip the changelog check
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate schema-next generation
4 participants
@lmolkova @jsuereth @joaopgrassi @trask