-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix a number of links to the opentelemetry-js-contrib repo #7289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
These links changed with the repo dir moves in open-telemetry/opentelemetry-js-contrib#2928
/fix:all |
❌ |
The
Attempting to run that locally eventually fails for me:
|
This was "resolved" by manually deleting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one tiny fix. Thanks!
complete the | ||
[packages named `resource-detector-*` in the opentelemetry-js-contrib repository](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an extra word here. I'm making a guess as to which one.
complete the | |
[packages named `resource-detector-*` in the opentelemetry-js-contrib repository](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages). | |
the | |
[packages named `resource-detector-*` in the opentelemetry-js-contrib repository](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages). |
These links changed with the repo dir moves in open-telemetry/opentelemetry-js-contrib#2928
(This follows up on other link fixes earlier today: #7276, #7285)