Skip to content

Fix a number of links to the opentelemetry-js-contrib repo #7289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Jul 9, 2025

These links changed with the repo dir moves in open-telemetry/opentelemetry-js-contrib#2928

(This follows up on other link fixes earlier today: #7276, #7285)

@trentm trentm requested a review from a team as a code owner July 9, 2025 21:05
@opentelemetrybot opentelemetrybot requested review from a team July 9, 2025 21:06
@trentm trentm changed the title Fix a number of links to the opentelemetry-js-contrib repo. Fix a number of links to the opentelemetry-js-contrib repo Jul 9, 2025
@trentm
Copy link
Contributor Author

trentm commented Jul 9, 2025

/fix:all

@opentelemetrybot
Copy link
Collaborator

@trentm
Copy link
Contributor Author

trentm commented Jul 10, 2025

The Links / REFCACHE updates? check failure includes this output:

...
ERROR: the files above have changed. Locally rerun `npm run test-and-fix` and commit changes

Attempting to run that locally eventually fails for me:

% npm run test-and-fix
...
> _hugo
> hugo --cleanDestinationDir -e dev --buildDrafts --buildFuture --baseURL http://localhost

Total in 5 ms
Error: failed to load modules: module "github.com/FortAwesome/Font-Awesome" not found in "/Users/trentm/tm/opentelemetry.io3/themes/github.com/FortAwesome/Font-Awesome"; either add it as a Hugo Module or store it in "/Users/trentm/tm/opentelemetry.io3/themes".: module does not exist

@opentelemetrybot opentelemetrybot requested a review from a team July 10, 2025 16:35
@trentm
Copy link
Contributor Author

trentm commented Jul 10, 2025

Attempting to run that [npm run test-and-fix] locally eventually fails for me:

This was "resolved" by manually deleting themes/docsy/node_modules, which I guess had incompatible content, then re-running npm install at the top-level. /shrug

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one tiny fix. Thanks!

Comment on lines +251 to +252
complete the
[packages named `resource-detector-*` in the opentelemetry-js-contrib repository](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's an extra word here. I'm making a guess as to which one.

Suggested change
complete the
[packages named `resource-detector-*` in the opentelemetry-js-contrib repository](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages).
the
[packages named `resource-detector-*` in the opentelemetry-js-contrib repository](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/packages).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

5 participants