-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[IA] Update Assisted and Automatic Instrumentation #7157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[IA] Update Assisted and Automatic Instrumentation #7157
Conversation
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review! Thanks!
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Severin Neumann <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some copy edits, but it looks good to me!
Co-authored-by: Tiffany Hrabusa <[email protected]>
Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: windsonsea <[email protected]>
Signed-off-by: windsonsea <[email protected]>
Signed-off-by: windsonsea <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Co-authored-by: Fabrizio Ferri-Benedetti <[email protected]>
Signed-off-by: windsonsea <[email protected]>
Co-authored-by: opentelemetrybot <[email protected]> Co-authored-by: Patrice Chalin <[email protected]> Co-authored-by: Severin Neumann <[email protected]>
ok... I butchered this PR myself 😅 trying to fix it |
hm ... we have a "bigger" problem:
With refactoring we break localizations that depend on the versions. Maybe it is time to move those versions out from the doc files into some dedicated location, i think we discussed this in the past. I'd like to get @chalin's perspective on that, until then this PR is blocked unfortunately. |
This PR is for #6932:
What's missing: