-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Adding Ukrainian homepage #6910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to pick needed part for hugo.toml form #5891
Thanks! Please address the various CI errors using the fix commands. You'll also need to add the |
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
Seems like there still are formatting and spelling issues. Could you check those? |
Thank you, @theletterf , for your help. For my part, as I wrote about it in Slack, I would ask you to implement one of the translation platforms (CrowdIn, Transifex, TranslateWiki, any other one you like). This would allow you to reduce the instructions for working with translations to a couple of sentences, something like: Use the <Name> platform to apply for a new language. Or translate materials for existing languages.
|
Regarding spelling, I think that action is needed on the part of the maintainers to enable a spell checker for the Ukrainian language. This is not available now. |
@theletterf could you setup cspell for Ukrainian and run tests one more time? |
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments, thanks.
I'll look into the cSpell config as soon as I can.
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
I've added the necessary Hugo and cSpell config. |
@chalin Thank you for your help with the adoption of the Ukrainian language and the addition of the Ukrainian spell checker. Regarding spelling (I repeat my question here for better visibility):
|
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
@Andygol - I'm not sure. We'll find out as we go along :). |
@Andygol apologies, missed that. |
@idvoretskyi Take your time, and don't feel pressured. |
Thank you all for your suggestions, based on which I offer you an updated version of the home page in Ukrainian. https://deploy-preview-6910--opentelemetry.netlify.app/uk/ ![]() |
@theletterf Any chance this PR will get the green light? |
we need @idvoretskyi or @kostiantynkovalchuk to give a "thumbsup" on the PR, since they are not yet a member of the org a comment with "LGTM" is all we need. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@svrnm could you re-run test 🙏, I've restored commit with .prettierignore. |
Thanks! That's what I actually wanted to write as a comment yesterday that we have to check how prettier works with Ukrainian, but you found out by now that it doesn't 😅 |
Uh oh!
There was an error while loading. Please reload this page.