Skip to content

Adding Ukrainian homepage #6910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Andygol
Copy link

@Andygol Andygol commented May 16, 2025

Copy link
Author

@Andygol Andygol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to pick needed part for hugo.toml form #5891

@theletterf
Copy link
Member

Thanks! Please address the various CI errors using the fix commands. You'll also need to add the default_lang_commit hash as per https://opentelemetry.io/docs/contributing/localization/#the-default_lang_commit-front-matter-field

Andygol added a commit to Andygol/opentelemetry.io that referenced this pull request May 19, 2025
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
@theletterf
Copy link
Member

Seems like there still are formatting and spelling issues. Could you check those?

@Andygol
Copy link
Author

Andygol commented May 19, 2025

Thank you, @theletterf , for your help.

For my part, as I wrote about it in Slack, I would ask you to implement one of the translation platforms (CrowdIn, Transifex, TranslateWiki, any other one you like).

This would allow you to reduce the instructions for working with translations to a couple of sentences, something like: Use the <Name> platform to apply for a new language. Or translate materials for existing languages.

This will greatly simplify and speed up the work of translation and review teams.

@Andygol
Copy link
Author

Andygol commented May 19, 2025

Regarding spelling, I think that action is needed on the part of the maintainers to enable a spell checker for the Ukrainian language. This is not available now.

@Andygol
Copy link
Author

Andygol commented May 20, 2025

@theletterf could you setup cspell for Ukrainian and run tests one more time?

chalin pushed a commit to Andygol/opentelemetry.io that referenced this pull request May 27, 2025
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, thanks.

I'll look into the cSpell config as soon as I can.

chalin pushed a commit to Andygol/opentelemetry.io that referenced this pull request May 27, 2025
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
chalin pushed a commit to Andygol/opentelemetry.io that referenced this pull request May 27, 2025
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
@chalin
Copy link
Contributor

chalin commented May 27, 2025

I've added the necessary Hugo and cSpell config.

@chalin chalin requested a review from idvoretskyi May 27, 2025 23:43
@Andygol
Copy link
Author

Andygol commented May 28, 2025

@chalin Thank you for your help with the adoption of the Ukrainian language and the addition of the Ukrainian spell checker. Regarding spelling (I repeat my question here for better visibility):

Do we need to add variants of the word in all declensions (there are 7 in Ukrainian), or can we somehow use wildcards?

@Andygol Andygol requested a review from chalin May 28, 2025 09:18
chalin pushed a commit to Andygol/opentelemetry.io that referenced this pull request May 28, 2025
Added `default_lang_commit` as per request open-telemetry#6910 (comment)
@chalin
Copy link
Contributor

chalin commented May 28, 2025

Do we need to add variants of the word in all declensions (there are 7 in Ukrainian), or can we somehow use wildcards?

@Andygol - I'm not sure. We'll find out as we go along :).

@idvoretskyi
Copy link
Member

@Andygol apologies, missed that.

@Andygol
Copy link
Author

Andygol commented Jun 4, 2025

@Andygol apologies, missed that.

@idvoretskyi Take your time, and don't feel pressured.

@Andygol
Copy link
Author

Andygol commented Jun 21, 2025

Thank you all for your suggestions, based on which I offer you an updated version of the home page in Ukrainian.

https://deploy-preview-6910--opentelemetry.netlify.app/uk/

image

@Andygol
Copy link
Author

Andygol commented Jul 5, 2025

@theletterf Any chance this PR will get the green light?

@svrnm
Copy link
Member

svrnm commented Jul 9, 2025

@theletterf Any chance this PR will get the green light?

we need @idvoretskyi or @kostiantynkovalchuk to give a "thumbsup" on the PR, since they are not yet a member of the org a comment with "LGTM" is all we need.

Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Andygol
Copy link
Author

Andygol commented Jul 10, 2025

@svrnm could you re-run test 🙏, I've restored commit with .prettierignore.

@svrnm
Copy link
Member

svrnm commented Jul 10, 2025

@svrnm could you re-run test 🙏, I've restored commit with .prettierignore.

Thanks! That's what I actually wanted to write as a comment yesterday that we have to check how prettier works with Ukrainian, but you found out by now that it doesn't 😅

@svrnm
Copy link
Member

svrnm commented Jul 10, 2025

looking good now, thanks for taking the time and effort, @Andygol !

I'd like to have @chalin take a look, he is back to office some time next week, so give us a few more days and then we hopefully can get started :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants