Skip to content

feat(redis): add support for redis v5 #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

adbista
Copy link
Contributor

@adbista adbista commented Jul 22, 2025

Which problem is this PR solving?

Short description of the changes

  • Add support for Redis v5.
  • Replaced deprecated semantic attributes with current semantic conventions
  • Updated tests

Copy link
Contributor

@seemk seemk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version number in README.md needs updating as well 🙏

@adbista adbista requested a review from seemk July 23, 2025 18:06
@adbista adbista force-pushed the feat/instrumentation-redis/redis5-support branch from 5f502a6 to 494563b Compare August 1, 2025 11:08
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.65%. Comparing base (c0593e6) to head (6a30b47).

Files with missing lines Patch % Lines
packages/instrumentation-redis/src/redis.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
- Coverage   89.84%   89.65%   -0.19%     
==========================================
  Files         188      188              
  Lines        9272     9262      -10     
  Branches     1901     1900       -1     
==========================================
- Hits         8330     8304      -26     
- Misses        942      958      +16     
Files with missing lines Coverage Δ
...instrumentation-redis/src/v2-v3/instrumentation.ts 17.64% <ø> (+0.50%) ⬆️
...instrumentation-redis/src/v4-v5/instrumentation.ts 72.13% <100.00%> (ø)
packages/instrumentation-redis/src/v4-v5/utils.ts 100.00% <100.00%> (ø)
packages/instrumentation-redis/src/redis.ts 76.92% <66.66%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@moekify
Copy link

moekify commented Aug 4, 2025

Would be great to get this merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support redis v5
4 participants