Skip to content

[ci] add checks on telemetry metrics exposed by the collectors #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Aug 2, 2025

Fixes #1071

@atoulme atoulme force-pushed the add_golden_tests branch 3 times, most recently from ef31bb0 to 07e0755 Compare August 2, 2025 19:30
@atoulme atoulme force-pushed the add_golden_tests branch 2 times, most recently from 752b875 to b26b5c8 Compare August 2, 2025 21:30
@atoulme atoulme force-pushed the add_golden_tests branch 4 times, most recently from ae59e06 to 73cff08 Compare August 3, 2025 03:05
@mowies
Copy link
Member

mowies commented Aug 4, 2025

I don't quite get why this test should be in the releases repo and not in the contrib repo directly next to the source code?

@atoulme atoulme marked this pull request as ready for review August 4, 2025 10:04
@atoulme atoulme requested a review from a team as a code owner August 4, 2025 10:04
@atoulme atoulme requested a review from MovieStoreGuy August 4, 2025 10:04
@atoulme
Copy link
Contributor Author

atoulme commented Aug 4, 2025

I don't quite get why this test should be in the releases repo and not in the contrib repo directly next to the source code?

The last patch release was needed because a replace statement had to be added for contrib’s manifest. I expect that collector telemetry continues to be a sticking point.

@mowies
Copy link
Member

mowies commented Aug 4, 2025

ok then i guess it's good to have the tests here. I did create a separate pipeline for regression tests recently, maybe that could be used here as well

@atoulme
Copy link
Contributor Author

atoulme commented Aug 5, 2025

ok then i guess it's good to have the tests here. I did create a separate pipeline for regression tests recently, maybe that could be used here as well

Is it this file? https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/.github/workflows/regression-tests.yaml
I am happy to piggy back on the current docker tests so we don't build the docker image twice.

@mowies
Copy link
Member

mowies commented Aug 5, 2025

either way is fine for me, i just wanted to mention it so you're aware of the option if it makes sense :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test on the contrib distribution checking metrics emitted out of the box
2 participants