-
Notifications
You must be signed in to change notification settings - Fork 203
[ci] add checks on telemetry metrics exposed by the collectors #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ef31bb0
to
07e0755
Compare
752b875
to
b26b5c8
Compare
b26b5c8
to
5324373
Compare
ae59e06
to
73cff08
Compare
73cff08
to
3531a52
Compare
I don't quite get why this test should be in the releases repo and not in the contrib repo directly next to the source code? |
The last patch release was needed because a replace statement had to be added for contrib’s manifest. I expect that collector telemetry continues to be a sticking point. |
ok then i guess it's good to have the tests here. I did create a separate pipeline for regression tests recently, maybe that could be used here as well |
Is it this file? https://github.com/open-telemetry/opentelemetry-collector-releases/blob/main/.github/workflows/regression-tests.yaml |
either way is fine for me, i just wanted to mention it so you're aware of the option if it makes sense :) |
Fixes #1071