Skip to content

[receiver/googlecloudpubsubreceiver] Add observed timestamp when using raw text encoding #41800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

dyl10s
Copy link

@dyl10s dyl10s commented Aug 5, 2025

Description

When using the raw text encoding the observed timestamp was not being set

Testing

Setup a local pub sub emulator and outputted to a file. Validated that there was no observed timestamp before the change, and then it did exist after the change.

@dyl10s dyl10s changed the title Pubsub add observed at timestamp [receiver/googlecloudpubsubreceiver] Pubsub add observed at timestamp Aug 5, 2025
@dyl10s dyl10s changed the title [receiver/googlecloudpubsubreceiver] Pubsub add observed at timestamp [receiver/googlecloudpubsubreceiver] Add observed timestamp when using raw text encoding Aug 5, 2025
Copy link
Contributor

@MovieStoreGuy MovieStoreGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure this is validated in tests so the behaviour is validated and captured when making future changes.

@alexvanboxel
Copy link
Contributor

alexvanboxel commented Aug 6, 2025

The internal encoders will be removed as stated in the readme. Use encoder extensions. In this case the textencoding. You can verify if the textencoding supports the behavior and open a PR there.

Copy link
Contributor

@alexvanboxel alexvanboxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this due to #41812

@dyl10s dyl10s closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants