fix utoprc templates to mention the correct path (changed by #484) #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix ! Emitting a warning for misplaced |
|
I think I'll work on it tomorrow (CEST) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path for
utoprcused to be$XDG_CONFIG_HOME/utoprc, but #484 has changed it to$XDG_CONFIG_HOME/utop/utoprc-- as the former was rightfully deemed incorrect.However, the
utoprc-darkandutoprc-lighttemplates were not updated in the process ; this PR fixes exactly that.It's worth mentioning that the aforementioned PR introduced a breaking change: people with their
utoprcin the previous location will not have code highlighting working anymore, and it is not necessarily clear why that is. I think there should be a transition period where a warning is shown if autoprcis found in.config/instead of.config/utop/.