Skip to content

refactor: do not export anonymous functions #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

refactor: do not export anonymous functions #1819

merged 1 commit into from
Jul 25, 2025

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Jul 24, 2025 •
edited
Loading

why:

  • people migrating from old package will look for the old function names, and this will allow to find them
  • anonymous functions are bad for debugging

@vonovak vonovak requested a review from johnf July 24, 2025 21:05
@vonovak vonovak force-pushed the vonovak/refactor_do_not_export_anonymous_functions branch from b452a9a to 3dc1ba0 Compare July 24, 2025 21:41
@vonovak vonovak force-pushed the vonovak/refactor_do_not_export_anonymous_functions branch from 3dc1ba0 to 84744c6 Compare July 24, 2025 21:45
@johnf johnf merged commit bb04ce0 into master Jul 25, 2025
14 of 16 checks passed
@johnf johnf deleted the vonovak/refactor_do_not_export_anonymous_functions branch July 25, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnf johnf Awaiting requested review from johnf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vonovak @johnf