feat: add 'use client' directive for RSC #1809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnf
force-pushed
the
vonovak/feat_add_use_client_directive_for_rsc
branch
from
c5f9337 to
c82a034
Compare
|
CONTRIBUTING has now had a significant overhaul |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The icon components are client components and should be marked with
'use client'directive for RSC usage.I haven't found the right way to apply the change from the template file to the individual packages; there's the standard
CONTRBUTINGfile but alsodocs/DEVELOPMENTwhich seems like they should be merged into one (?) - probably theCONTRBUTINGfile which is a the expected place to find this stuff.