Skip to content

Update Expo docs #1806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 18, 2025
Merged

Update Expo docs #1806

merged 2 commits into from
Jul 18, 2025

Conversation

umarhadi
Copy link
Contributor

This pull request updates the docs/SETUP-EXPO.md file to clarify the setup process for react-native-vector-icons with Expo and provide guidance on avoiding common build issues. Key changes include marking the font config plugin setup as optional, reorganizing instructions, and adding a new section on avoiding manual font duplication.

Updates to setup instructions:

  • Updated the section title to "Set up font config plugin (Optional)" and clarified that using the config plugin is optional but recommended for preloading fonts at build time.
  • Simplified and reorganized the steps for adding the font config plugin to app.config.js or app.config.json.

New guidance on avoiding font duplication:

  • Added a new section, "⚠️ Important: Avoid Manual Font Duplication," explaining that recent versions of react-native-vector-icons handle font bundling automatically for native platforms.
  • Included a warning about potential iOS build errors caused by duplicate font copies and provided a link to a related GitHub issue for further details.
  • Provided an example configuration for adding only custom fonts to the expo-font plugin, along with a caution against adding fonts from node_modules/@react-native-vector-icons/Fonts.

Copy link
Collaborator

@vonovak vonovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out.

This is good but it's conflicting a little: we say that using the config plugin is recommended, but in light of the duplication, I think we should remove that section altogether, and keep just "Avoid Manual Font Duplication" section.

Thank you!

@vonovak vonovak merged commit 081050a into oblador:master Jul 18, 2025
4 of 28 checks passed
@umarhadi umarhadi deleted the umarhadi-expo-docs branch July 21, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants