Move direct dep on rnc/cli-tools to dev/peer deps

[friederbluemle]

This decouples @react-native-vector-icons/common from a specific version (currently ^17.0.0) of @react-native-community/cli-tools.

The only function currently used is resolveNodeModuleDir, which in this form first appeared in cli-tools 9.0.0 (which is why the peer dependency was set to ">=9.0.0").

Different version of React Native use different versions of @react-native-community/cli-tools. There should be no reason to pull in duplicates.

[vonovak]

Hello, I'm afraid that this isn't quite right;
this package should work even in projects without @react-native-community/cli-tools installed (expo projects). common depends on resolveNodeModuleDir imported from @react-native-community/cli-tools, and so @react-native-community/cli-tools should remain as a dependency. In the future we can remove that dependency by shipping resolveNodeModuleDir with the package.

For now what I believe we can do is to relax the range to be "@react-native-community/cli-tools": ">=17 <21" because we know the function is present in those versions

[johnf]

Closing in favour of #1812

[friederbluemle]

Thanks for taking a look and for your comment @vonovak 👍

And thanks @johnf for removing the dependency altogether. I agree that's definitely the best option!